Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Add magic primitive #1766

Merged
merged 2 commits into from
Mar 24, 2023
Merged

feat(compiler): Add magic primitive #1766

merged 2 commits into from
Mar 24, 2023

Conversation

ospencer
Copy link
Member

Closes #1149

@ospencer ospencer self-assigned this Mar 18, 2023
spotandjake
spotandjake reviewed Mar 18, 2023
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

phated
phated approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so the preview binaries run @ospencer's talk code. We can still bikeshed and change the term before release.

@phated phated added this pull request to the merge queue Mar 24, 2023
spotandjake
spotandjake approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well, as Blaine said we can figure out a better name for it later.

Merged via the queue into main with commit a28ebb4 Mar 24, 2023
@phated phated deleted the oscar/magic branch March 24, 2023 16:05
@github-actions github-actions bot mentioned this pull request Mar 24, 2023
Merged
av8ta pushed a commit to av8ta/grain that referenced this pull request Apr 11, 2023
@ospencer @phated
feat(compiler): Add magic primitive (grain-lang#1766)
a7b0253 
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@spotandjake spotandjake spotandjake approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide Obj.magic primitive for runtime use
3 participants
@ospencer @phated @spotandjake