Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Type aliasing in use statements #1887

Merged
merged 2 commits into from
Aug 26, 2023
Merged

fix(compiler): Type aliasing in use statements #1887

merged 2 commits into from
Aug 26, 2023

Conversation

alex-snezhko
Copy link
Member

Closes #1869

spotandjake
spotandjake approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

ospencer
ospencer reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests where you annotate using the alias?

peblair
peblair approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@peblair peblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with the test that @ospencer requested)

@alex-snezhko
Copy link
Member Author

Added a test with annotation

@phated phated requested a review from ospencer August 24, 2023 01:48
ospencer
ospencer approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, great work!

@phated phated added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@phated phated added this pull request to the merge queue Aug 26, 2023
Merged via the queue into grain-lang:main with commit 79ab814 Aug 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peblair peblair peblair approved these changes

@ospencer ospencer ospencer approved these changes

@spotandjake spotandjake spotandjake approved these changes

@phated phated Awaiting requested review from phated phated is a code owner

Assignees

@alex-snezhko alex-snezhko

Labels
compiler enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lang: Re-providing aliased types fails
5 participants
@alex-snezhko @peblair @ospencer @spotandjake @phated