Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): Support goto definition on exceptions #1895

Merged
merged 5 commits into from
Sep 12, 2023
Merged

feat(lsp): Support goto definition on exceptions #1895

merged 5 commits into from
Sep 12, 2023

Conversation

spotandjake
Copy link
Member

Adds support for goto definition on exceptions.

@spotandjake spotandjake self-assigned this Jul 20, 2023
marcusroberts
marcusroberts approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@spotandjake spotandjake added the lsp Issues related to the language server. label Jul 21, 2023
phated
phated requested changes Aug 20, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

compiler/src/language_server/sourcetree.re Outdated Show resolved Hide resolved
phated
phated approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it in the stdlib and it jumps correctly 🎉

@phated phated added this pull request to the merge queue Sep 12, 2023
Merged via the queue into grain-lang:main with commit 218b2f0 Sep 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

@ospencer ospencer Awaiting requested review from ospencer ospencer is a code owner

Assignees

@spotandjake spotandjake

Labels
compiler enhancement lsp Issues related to the language server.
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spotandjake @phated @ospencer @marcusroberts