chore(stdlib)!: Switch to using records for getInternalStats
#1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts and
jozanza
as code owners
|
Looks like one of the provides snapshots gets updated because of a dependency on the stdlib |
phated
requested changes
Aug 20, 2023
|
All Fixed |
phated
requested changes
Aug 20, 2023
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
phated
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some todos left over from #190 being closed, and switches
getInternalStatsfrom returning a tuple to a record.This is marked as breaking as we change the signature of
getInternalStats