feat(runtime): Allow modulo on floating point numbers #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
jozanza and
phated
as code owners
peblair
reviewed
Sep 28, 2023
|
@spotandjake #1993 was the major reason you were seeing the DecRefError. While debugging, I noticed some places we're a bit sloppy when we need to hold on to references, but I'll address those separately. |
spotandjake
force-pushed
the
spotandjake-fmod
branch
from
c7c9ad7
to
ed5a05d
Compare
ospencer
reviewed
Jan 29, 2024
ospencer
approved these changes
Jan 30, 2024
ospencer
changed the title
phated
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds floating point modulo support closing #1371