Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grainfmt: Comment lost when preceding a number #2042

Closed
marcusroberts opened this issue Feb 20, 2024 · 1 comment · Fixed by #2044
Closed

Grainfmt: Comment lost when preceding a number #2042

marcusroberts opened this issue Feb 20, 2024 · 1 comment · Fixed by #2044
Assignees
Labels

Comments

@marcusroberts
Copy link
Member

If I write a bizzare comment like this

print(/*a*/ 1 /*b*/)

The first comment is lost after formatting

print(1 /*b*/)

This is happening because the location of the argument is wrong (says @ospencer )

@ospencer
Copy link
Member

In particular, this issue is specific to positive numbers. The way we check for the dash of a negative number results in an incorrect location for the argument (but not the actual number itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
3 participants