Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Show correct error when module traps #2050

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Mar 2, 2024

If an assertion fails, we show Unable to instantiate WebAssembly module which is incorrect. This ensures that message only shows when the module failed to instantiate.

@ospencer ospencer self-assigned this Mar 2, 2024
@phated phated added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit 88560f2 Mar 2, 2024
12 checks passed
@phated phated deleted the oscar/js-error branch March 2, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants