Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Don't trigger recompilation for unnecessary compiler flags #2106

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented May 4, 2024

No description provided.

Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval from me, I did my best to decide if your digestable/notdigestable was correct, but trust you on it!

@@ -1,3 +1,6 @@
// Digestable configurations are ones that affect Grain object files.
// Any config options that don't change object files should be marked
// NotDigestable to avoid unnecessary recompiles
type digestable =
| Digestable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit typo on digestible

@@ -353,17 +360,24 @@ let stdlib_dir =
~conv=option_conv(Cmdliner.Arg.string),
~doc="Path to the standard library (stdlib) directory",
~env="GRAIN_STDLIB",
~digestable=Digestable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remind me why the stdlib option would be Digestable but include_dirs is not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to be, good catch.

@ospencer
Copy link
Member Author

@alex-snezhko Made those changes.

@ospencer ospencer enabled auto-merge July 28, 2024 21:04
@ospencer ospencer added this pull request to the merge queue Jul 28, 2024
Merged via the queue into main with commit 4275c17 Jul 28, 2024
12 checks passed
@ospencer ospencer deleted the oscar/digest branch July 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants