You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it should make sense to add a #[inline] declaration to most functions generated by faust.
here a example how the generated code would look like: example
The main benefit of explicit inline declaration is that functions can be in-lined across crate boundaries.
there are some things to consider in relation to this as discussed here: https://matklad.github.io/2021/07/09/inline-in-rust.html
the small examples and faust2* projects should not be affected by this change as far as I understood.
In practice, what kind of functions are called "often enough" to justify inlining ? get_param/set_param/compute possibly ? Most of the others are called like once at init time or a few times like build_user_interface.
Any concrete use case of the "inlining across crate boundaries" you can see ?
I think it should make sense to add a
#[inline]
declaration to most functions generated by faust.here a example how the generated code would look like:
example
The main benefit of explicit inline declaration is that functions can be in-lined across crate boundaries.
there are some things to consider in relation to this as discussed here:
https://matklad.github.io/2021/07/09/inline-in-rust.html
the small examples and faust2* projects should not be affected by this change as far as I understood.
do you have opinions on this?
@bluenote10
The text was updated successfully, but these errors were encountered: