Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hardcoding argv in the manifest #761

Closed
mkow opened this issue Jul 16, 2022 · 1 comment · Fixed by #858
Closed

Support for hardcoding argv in the manifest #761

mkow opened this issue Jul 16, 2022 · 1 comment · Fixed by #858
Assignees

Comments

@mkow
Copy link
Member

mkow commented Jul 16, 2022

Description of the problem

We currently have loader.argv_src_file for reading hardcoded args from a file, but would be nice to have a way to specify them directly in the manifest in case they are short and simple. I originally couldn't add this when implementing loader.argv_src_file, because back then we didn't use TOML and the old syntax was too primitive to be able to support such features.

Proposed syntax

loader.argv = ["arg0", "arg1", "arg2"]

Specifying more than one from {loader.argv, loader.argv_src_file, loader.insecure__use_cmdline_argv} should be treated as an error.
Not sure whether loader.argv0_override will still be useful after this change, I don't really remember what was the intended use case (something with busybox probably?).

@oshogbo
Copy link
Contributor

oshogbo commented Jul 18, 2022

I can look into this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants