This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Deprecate/remove changing configuration #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefMa
changed the title
|
Don't deprecate it, remove it completely. It's part of the |
StefMa
force-pushed
the
cleanup/remove_changing_conf
branch
from
eb179f7 to
a5ac1c9
Compare
passsy
reviewed
Jul 11, 2017
| @@ -139,9 +138,6 @@ public void activityChangingConfiguration_retainTrue_backstackFalse_dkATrue() { | |||
| assertThat(fragment.getPresenter().isDestroyed()).isTrue(); | |||
| assertThat(mSavior.getPresenterCount()).isEqualTo(0); | |||
|
|
|||
| // When the Activity is changing its configuration. | |||
There was a problem hiding this comment.
this comment should stay although the activity parameters don't change
StefMa
force-pushed
the
cleanup/remove_changing_conf
branch
2 times, most recently
from
204091f to
109e5eb
Compare
StefMa
force-pushed
the
cleanup/remove_changing_conf
branch
from
109e5eb to
a7052f2
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will declare
DelegatedTiActivity#isActivityChangingConfigurationsas deprecated. We don't need that call anymore. Our internal API have removed the call to it.Public API's are set to deprecated with a hint what to use now.
With that change I also removed the generic from the
DelegatedTiActivtiy. It's not needed...