Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AirBnbs ESLint Config #24

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

grantwforsythe
Copy link
Owner

@grantwforsythe grantwforsythe commented Aug 2, 2024

Pull Request Template

Beefup Linter

I wanted to be more strict with my linting rules so I extended from AirBnbs config.

Type of Change

  • Feature
  • Fix
  • Refactor
  • UI/UX improvement

Description

[Provide a detailed explanation of the changes you have made. Include the reasons behind these changes and any relevant context. Link any related issues. For UI/UX changes, include a screenshot or recording of the changes.]

Testing

[Detail the testing you have performed to ensure that these changes function as intended. Include information about any added tests.]

Impact

[Discuss the impact of your changes on the project. This might include effects on performance, new dependencies, or changes in behavior.]

Additional Information

[Any additional information that reviewers should be aware of.]

Checklist

  • My code adheres to the coding and style guidelines of the project as specified in CONTRIBUTING.md.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

cypress bot commented Aug 2, 2024



Test summary

8 0 0 0


Run details

Project Default Project
Status Passed
Commit 9d40658 ℹ️
Started Aug 2, 2024 6:31 AM
Ended Aug 2, 2024 6:31 AM
Duration 00:17 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.48%. Comparing base (a729255) to head (f724d0d).

Files Patch % Lines
src/app/state/selectors/report.selectors.ts 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   96.80%   95.48%   -1.32%     
==========================================
  Files          20       19       -1     
  Lines         250      177      -73     
  Branches       20       20              
==========================================
- Hits          242      169      -73     
  Misses          5        5              
  Partials        3        3              
Files Coverage Δ
src/app/shared/services/auth/auth.guard.ts 100.00% <ø> (ø)
src/app/shared/services/auth/auth.interceptor.ts 0.00% <ø> (-50.00%) ⬇️
src/app/shared/services/auth/auth.service.ts 84.84% <100.00%> (ø)
src/app/state/effects/budget-cards.effects.ts 100.00% <100.00%> (ø)
src/app/state/effects/report.effects.ts 100.00% <100.00%> (ø)
src/app/state/reducers/budget-cards.reducers.ts 100.00% <ø> (ø)
src/app/state/reducers/report.reducers.ts 100.00% <ø> (ø)
src/app/state/selectors/budget-cards.selectors.ts 100.00% <100.00%> (ø)
src/app/state/selectors/report.selectors.ts 95.91% <90.90%> (-0.64%) ⬇️

... and 1 file with indirect coverage changes

@grantwforsythe grantwforsythe merged commit 4311c8d into main Aug 2, 2024
7 of 9 checks passed
@grantwforsythe grantwforsythe deleted the ci/use-airbnbs-eslint-conf branch August 2, 2024 06:32
Copy link

cypress bot commented Aug 2, 2024



Test summary

8 0 0 0


Run details

Project Default Project
Status Passed
Commit 4311c8d
Started Aug 2, 2024 6:33 AM
Ended Aug 2, 2024 6:33 AM
Duration 00:15 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant