Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestLoader/allows_clearAll_values_in_cache fails non-deterministically #76

Open
tonyghita opened this issue Apr 1, 2021 · 0 comments · May be fixed by #77
Open

TestLoader/allows_clearAll_values_in_cache fails non-deterministically #76

tonyghita opened this issue Apr 1, 2021 · 0 comments · May be fixed by #77

Comments

@tonyghita
Copy link
Member

@mjq discovered an issue with a unit test while fixing an incorrect CI configuration in #73:

I can reproduce this failure, but only rarely - on my laptop, the test failed only 3 out of 10000 runs.

$ go test -v -race -coverprofile=coverage.txt -covermode=atomic -count 10000 | grep FAIL
--- FAIL: TestLoader (0.00s)
    --- FAIL: TestLoader/allows_clearAll_values_in_cache (0.02s)
--- FAIL: TestLoader (0.00s)
    --- FAIL: TestLoader/allows_clearAll_values_in_cache (0.02s)
--- FAIL: TestLoader (0.00s)
    --- FAIL: TestLoader/allows_clearAll_values_in_cache (0.02s)
FAIL
FAIL	github.com/graph-gophers/dataloader/v6	390.973s

We should dig into what causes this test to fail non-deterministically and then fix the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky WithClearCacheOnBatch test graph-gophers/dataloader
1 participant
@tonyghita