Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox drawer collapses/expands when field focus is changed #2192

Open
cetrix13 opened this issue Feb 12, 2024 · 8 comments
Open

Firefox drawer collapses/expands when field focus is changed #2192

cetrix13 opened this issue Feb 12, 2024 · 8 comments

Comments

@cetrix13
Copy link

cetrix13 commented Feb 12, 2024

Describe the Bug

In the latest version of GraphCommerce https://graphcommerce-git-alt-graphcommerce.vercel.app/account/signin and previous versions there is an issue with a drawer on mobile Firefox browser. It collapses/expands, when one changes focus from the field which has on screen keyboard to the field which doesn't.

Firefox_mobile_bug.mp4

Expected Behavior

The drawer shouldn't collapse/expand when one changes focus on the form.

To Reproduce

  • Open sign up drawer with the form in the latest mobile Firefox
  • Go to the 'Create Account' form
  • Set focus on the email input field
  • Set focus on the Prefix input field
  • Observe that the drawer collapses/expands
@machielkreiken
Copy link
Member

Hello Cetrix, thank you for reporting the issue. I will create an issue in our internal system too.
We will have a look to see how we can fix this.

@machielkreiken
Copy link
Member

GCOM-1338

@paales
Copy link
Member

paales commented Mar 27, 2024

@cetrix13 A related issue to drawers in Firefox has since been fixed. Can you validate that it works on https://graphcommerce.vercel.app?

@paales paales closed this as completed Jul 4, 2024
@cetrix13
Copy link
Author

cetrix13 commented Sep 5, 2024

@paales Verified, it looks good. Thank you.

@cetrix13
Copy link
Author

@paales Could you please provide a reference, where it was fixed.

@paales
Copy link
Member

paales commented Sep 11, 2024

@cetrix13 I think this is the reference 1d9be85

@shadmaan-jde
Copy link

@paales Its not the right reference. Bug was created 12th Feb 2024 and the reference is from the 31th May 2023

@paales
Copy link
Member

paales commented Sep 13, 2024

This one maybe? 29407d2 Was done a few weeks before my comment so that might align.

@paales paales reopened this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants