fix(info): always add rootfield to info object

The rootfield wasn't added to the info object if it is a scalas type. Closes #24
dotansimha · Jan 12, 2018 · 264fb44 · 264fb44
1 parent 926b603
commit 264fb44
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/info.test.ts b/src/info.test.ts
@@ -80,7 +80,7 @@ test('buildInfoForAllScalars: minimal static root field', t => {
   }
   `)
   const info = buildInfoForAllScalars('count', schema, 'query')
-  t.is(info.fieldNodes.length, 0)
+  t.is(info.fieldNodes.length, 1)
 })
 
 test('buildInfoForAllScalars: mutation', t => {

diff --git a/src/info.ts b/src/info.ts
@@ -32,9 +32,10 @@ export function buildInfoForAllScalars(
   const fieldNodes: FieldNode[] = []
   const type = getTypeForRootFieldName(rootFieldName, operation, schema)
 
+  let selections: FieldNode[] | undefined
   if (type instanceof GraphQLObjectType) {
     const fields = type.getFields()
-    const selections = Object.keys(fields)
+    selections = Object.keys(fields)
       .filter(f => isScalar(fields[f].type))
       .map<FieldNode>(fieldName => {
         const field = fields[fieldName]
@@ -43,15 +44,16 @@ export function buildInfoForAllScalars(
           name: { kind: 'Name', value: field.name },
         }
       })
-    const fieldNode: FieldNode = {
-      kind: 'Field',
-      name: { kind: 'Name', value: rootFieldName },
-      selectionSet: { kind: 'SelectionSet', selections },
-    }
+  }
 
-    fieldNodes.push(fieldNode)
+  const fieldNode: FieldNode = {
+    kind: 'Field',
+    name: { kind: 'Name', value: rootFieldName },
+    selectionSet: selections ? { kind: 'SelectionSet', selections } : undefined,
   }
 
+  fieldNodes.push(fieldNode)
+
   const parentType = {
     query: () => schema.getQueryType(),
     mutation: () => schema.getMutationType()!,