Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypescriptGenerator: allow null for nullable graphql types #197

Closed
wants to merge 1 commit into from
Closed

TypescriptGenerator: allow null for nullable graphql types #197

wants to merge 1 commit into from

Conversation

kinolaev
Copy link

@kinolaev kinolaev commented Dec 3, 2018

@maticzav maticzav closed this in ee54b24 Dec 10, 2018
@schickling
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maticzav
Copy link
Collaborator

Hey @kinolaev 👋,

Thank you for creating this PR! I took your PR as a starting point for the current implementation of nullable types support however tackled it a bit differently as I didn't want to increase code complexity by introducing new arguments to functions.

Besides that, I believe you ignored #156.

Thanks again! It would be quite neat if you could verify everything is working as you would expect. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kinolaev @schickling @maticzav