Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False boolean values always null #116

Closed
d-winter opened this issue Sep 20, 2016 · 5 comments
Closed

False boolean values always null #116

d-winter opened this issue Sep 20, 2016 · 5 comments

Comments

@d-winter
Copy link

d-winter commented Sep 20, 2016 •
edited
Loading

Hi,
when inserting a boolean field in a mutation with the value false results in the value null.

screen shot 2016-09-20 at 13 44 52
Querying for records with false boolean values results also to null.
Is this a bug? I am using 1.9.2.

Another thing is the serialization of JSON. When I request json from the client, I only get "[object Object]", not the serialized JSON as a string. Thought this should be the correct behaviour?
Thanks in advance!
Daniel
@calebmer
Copy link
Collaborator

Might be related to #108, I’ll definetly explore.

@calebmer
Copy link
Collaborator

As for JSON, yeah that’s a bug. Look at #102 though for more conversation on how we should handle the JSON type.

@calebmer calebmer mentioned this issue Sep 21, 2016
Merged
@calebmer
Copy link
Collaborator

There’s a PR in now for the false bug, just waiting for a review and I’ll release 👍 #120

@calebmer calebmer mentioned this issue Sep 21, 2016
Merged
@calebmer
Copy link
Collaborator

There’s also now a PR for JSON type serialization #121

@calebmer
Copy link
Collaborator

Fix is in 1.9.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calebmer @d-winter