-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruru rendering issues #2103
Comments
Are these Ruru specific issues, or are they issues in the upstream project GraphiQL? If the latter, please file there. It’s also common to use GitHub-flavoured Since GraphiQL is the reference implementation of a GraphQL IDE, I defer to its choices, even if I don’t agree with them. |
I don't know. I'd guess like 50/50? There's an obvious problem with the Postgraphile SQL parser given the flaky behaviour in the video. However, it's likely that the "hidden second paragraph" issue is graphiql upstream (though I never had issues with this until I started trying to record reproduction videos so that seems flaky as well 🤔. Closest I could find for now was graphql/graphiql#3348).
I was not aware of this "feature" (bug imo). According to stack overflow, this is no longer a documented feature:
I guess it makes sense for Postgraphile's parser to output the comment as-written and rely on the browser to render it nicely - as long as Postgraphile's parser does not itself add I found a PR in upstream to fix this: graphql/graphiql#3414 |
Summary
Not sure how to put this down in a good way (sorry for multi-bug). Basically, Ruru does not behave as I would expect.
Screencast.from.2024-06-21.21.07.52.webm
Some issues:
<br>
s in the html output for single line breaks which causes bad formatting. For example, the newline between "this" and "regex" at the end of this doc is unexpected:Steps to reproduce
This is the comment I was using:
Expected results
The output in ruru should not be flaky and it should adhere to proper markdown (where single newlines are ignored)
Actual results
See above
Additional context
postgraphile
:5.0.0-beta.26
ruru
:2.0.0-beta.13
Google Chrome:
Version 125.0.6422.141 (Official Build) (64-bit)
The text was updated successfully, but these errors were encountered: