Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for failed transactions #1055

Open
jjgonecrypto opened this issue Jul 12, 2019 · 5 comments
Open

Add support for failed transactions #1055

jjgonecrypto opened this issue Jul 12, 2019 · 5 comments

Comments

@jjgonecrypto
Copy link

jjgonecrypto commented Jul 12, 2019

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
Transactions do not support the status flag from receipts, nor do they support the error reason (gas or revert reason). Moreover only successful call transactions will invoke a subgraph's handlers.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior?
That a failed transaction from an invocation of a call handler would:
a) Trigger the call handler in the subgraph
b) That the EthereumTransaction class would contain the following:
* a flag for status reflecting the success status of the transaction
* an errorType - reverted or out-of-gas (others?)
* the revertReason if any (which is easy to surface in ethers and web3)

The main motivation for something like this is for projects, such as ours, to track errors users have when interacting with our contracts (for monitoring tools). As users pay gas even for failed transactions, it's critical to minimize these where possible. It's even more important when they call our functions from their own contracts. As you can imagine, these calls are harder to track as unlike regular transactions invoking our contracts directly (where we are the to destination of the transaction) - their to destination is their contract which is calling ours by reference in the code.

@ghost
Copy link

ghost commented Jan 24, 2021

any documentation for this?

@kowalski
Copy link

👍 I also need this

@jakerockland
Copy link

Definitely an important ask from us over at Art Blocks 👋 💜

@vuquang23
Copy link

Need this too

@azf20
Copy link
Contributor

azf20 commented Oct 30, 2022

Thanks! @sduchesneau this might be an interesting Firehose-powered addition as the data is more readily available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants