Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding data sources in graft not working #3960

Closed
leoyvens opened this issue Sep 20, 2022 · 0 comments · Fixed by #3989
Closed

Adding data sources in graft not working #3960

leoyvens opened this issue Sep 20, 2022 · 0 comments · Fixed by #3989
Assignees

Comments

@leoyvens
Copy link
Collaborator

It's a reasonable use case for grafting to add a data source with a start block larger than the graft block. However the recent change to a private data sources table broke this, because it assumes that the manifest index of the templates is the same as in the source subgraph, and adding a data source will increase the manifest index. This can be fixed by translating the manifest indexes when grafting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant