Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapConverter throws if extensions property is null #601

Closed
PSanetra opened this issue Nov 22, 2023 · 0 comments · Fixed by #602
Closed

MapConverter throws if extensions property is null #601

PSanetra opened this issue Nov 22, 2023 · 0 comments · Fixed by #602

Comments

@PSanetra
Copy link

It seems like GraphQL.Client.Serializer.Newtonsoft.MapConverter expects properties of type Map to be never null. This is confusing as even the GraphQLResponse class declares the extensions property as Map?:

public Map? Extensions { get; set; }

Related code:

throw new ArgumentException("This converter can only parse when the root element is a JSON Object.");

There is also a related StackOverflow issue: https://stackoverflow.com/q/70884409/4019462

@rose-a rose-a linked a pull request Nov 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant