Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'clientMutationId' needed anymore? #107

Closed
fiyazbinhasan opened this issue Apr 28, 2021 · 1 comment
Closed

Is 'clientMutationId' needed anymore? #107

fiyazbinhasan opened this issue Apr 28, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists spec compliance The change is intended to solve the problem of inconsistency with the official GraphQL specification

Comments

@fiyazbinhasan
Copy link

As of this pull request, facebook/relay@3838691

RelayModern has no requirements on mutations beyond the general mutation specs. Specifically, the additional requirements that are no longer required are:

  • clientMutationId (even RelayClassic only required this because of FB internal reasons)
  • $input objects, with RelayModern the input to mutations can come either as one big object or multiple mutation arguments.

As clientMutationId is no longer needed in RelayModern, we can remove the MutationInputGraphType altogether. Instead, we can use the actual InputGraphType. Do you guys agree?

@Shane32
Copy link
Member

Shane32 commented Apr 28, 2021

Double-post - duplicate of #106

@Shane32 Shane32 closed this as completed Apr 28, 2021
@sungam3r sungam3r added duplicate This issue or pull request already exists spec compliance The change is intended to solve the problem of inconsistency with the official GraphQL specification labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists spec compliance The change is intended to solve the problem of inconsistency with the official GraphQL specification
Projects
None yet
Development

No branches or pull requests

3 participants