create factories to avoid using slow typeof each time an error is thrown

Author: EmrysMyrddin

packages/plugins/persisted-operations/src/index.ts

@@ -93,6 +93,19 @@ export function usePersistedOperations<
   const operationASTByRequest = new WeakMap<Request, DocumentNode>()
   const persistedOperationRequest = new WeakSet<Request>()
 
+  const notFoundErrorFactory = createErrorFactory(
+    'PersistedQueryNotFound',
+    customErrors?.notFound,
+  )
+  const keyNotFoundErrorFactory = createErrorFactory(
+    'PersistedQueryKeyNotFound',
+    customErrors?.keyNotFound,
+  )
+  const persistentQueryOnlyErrorFactory = createErrorFactory(
+    'PersistedQueryOnly',
+    customErrors?.persistedQueryOnly,
+  )
+
   return {
     async onParams(payload) {
       const { request, params, setParams } = payload
@@ -103,32 +116,20 @@ export function usePersistedOperations<
             ? allowArbitraryOperations
             : await allowArbitraryOperations(request)) === false
         ) {
-          throw createPersistedOperationError(
-            'PersistedQueryOnly',
-            payload,
-            customErrors?.persistedQueryOnly,
-          )
+          throw persistentQueryOnlyErrorFactory(payload)
         }
         return
       }
 
       const persistedOperationKey = extractPersistedOperationId(params)
 
       if (persistedOperationKey == null) {
-        throw createPersistedOperationError(
-          'PersistedQueryNotFound',
-          payload,
-          customErrors?.keyNotFound,
-        )
+        throw keyNotFoundErrorFactory(payload)
       }
 
       const persistedQuery = await getPersistedOperation(persistedOperationKey)
       if (persistedQuery == null) {
-        throw createPersistedOperationError(
-          'PersistedQueryNotFound',
-          payload,
-          customErrors?.notFound,
-        )
+        throw notFoundErrorFactory(payload)
       }
 
       if (typeof persistedQuery === 'object') {
@@ -161,16 +162,19 @@ export function usePersistedOperations<
   }
 }
 
-function createPersistedOperationError(
+function createErrorFactory(
   defaultMessage: string,
-  payload: OnParamsEventPayload,
   options?: CustomErrorFactory,
 ) {
   if (typeof options === 'string') {
-    return createGraphQLError(options)
+    return () => createGraphQLError(options)
   }
+
   if (typeof options === 'function') {
-    return options(payload)
+    return options
+  }
+
+  return () => {
+    return createGraphQLError(options?.message ?? defaultMessage, options)
   }
-  return createGraphQLError(options?.message ?? defaultMessage, options)
 }

website/src/pages/docs/features/persisted-operations.mdx

@@ -307,7 +307,7 @@ const yoga = createYoga({
           }
         },
         // Or customize with a factory function allowing you to use your own error class or format
-        onlyPersisted: () => {
+        persistedQueryOnly: () => {
           return new CustomErrorClass('Only Persisted Operations are allowed')
         }
       }