fix(router): use 503 instead of 500 when router is not ready (#512)

Author: dotansimha

bin/router/src/http_utils/probes.rs

@@ -14,6 +14,6 @@ pub async fn readiness_check_handler(
     if schema_state.is_ready() {
         web::HttpResponse::Ok()
     } else {
-        web::HttpResponse::InternalServerError()
+        web::HttpResponse::ServiceUnavailable()
     }
 }

e2e/src/hive_cdn_supergraph.rs

@@ -204,7 +204,7 @@ mod hive_cdn_supergraph_e2e_tests {
               source: hive
               endpoint: http://{host}/supergraph
               key: dummy_key
-              poll_interval: 500ms
+              poll_interval: 800ms
         "#,
         ))
         .await
@@ -234,7 +234,7 @@ mod hive_cdn_supergraph_e2e_tests {
         assert_eq!(types_arr.len(), 14);
 
         // Now wait for the schema to be reloaded and updated
-        sleep(Duration::from_millis(600)).await;
+        sleep(Duration::from_millis(900)).await;
         mock2.assert();
 
         let resp = test::call_service(

e2e/src/supergraph.rs

@@ -1,5 +1,5 @@
 #[cfg(test)]
-mod jwt_e2e_tests {
+mod supergraph_e2e_tests {
     use std::{sync::Arc, time::Duration};
 
     use ntex::{time, web::test};
@@ -207,22 +207,15 @@ mod jwt_e2e_tests {
         mock1.assert();
 
         let app_clone = test_app.app.clone();
-        let resp_handle = ntex::rt::spawn(async move {
-            let response = test::call_service(
-                &app_clone.clone(),
-                init_graphql_request("{ users { id name reviews { id body } } }", None)
-                    .to_request(),
-            )
-            .await;
-            assert!(response.status().is_success(), "Expected 200 OK");
-            let body = test::read_body(response).await;
-            let json_body: Value = from_slice(&body).unwrap();
-
-            json_body
-        });
+        let response = test::call_service(
+            &app_clone.clone(),
+            init_graphql_request("{ users { id name reviews { id body } } }", None).to_request(),
+        )
+        .await;
+        assert!(response.status().is_success(), "Expected 200 OK");
+        let body = test::read_body(response).await;
+        let resp: Value = from_slice(&body).unwrap();
 
-        ntex::time::sleep(Duration::from_millis(100)).await;
-        let resp = resp_handle.await.unwrap();
         mock2.assert();
 
         assert!(resp["data"].is_object());