Optional fields not working?

[seed-of-apricot]

Screenshot

Description

I have

export const Mutation = mutationType({
  definition(t) {
    t.nonNull.field("upsertOneGame", {
      type: "Game",
      args: {
        data: arg({ type: nonNull(GameUpsertInput) }),
      },
      async resolve(_, args, ctx: Context) {
        return ctx.prisma.game.upsert({
          where: {
            id: args.data.id,
          },
          create: args.data,
          update: {},
        });
      },
    });
  },
});

// ... other inputObjectTypes

const GameCreateWithoutTeamsInput = inputObjectType({
  name: "GameCreateWithoutTeamsInput",
  definition(t) {
    t.string("id");
    t.nonNull.string("name");
    t.nonNull.field("setting", {
      type: SettingCreateNestedOneWithoutGameInput,
    });
  },
});

const SettingCreateNestedOneWithoutGameInput = inputObjectType({
  name: "SettingCreateNestedOneWithoutGameInput",
  definition(t) {
    t.field("connect", { type: WhereUniqueInput });
    t.field("connectOrCreate", {
      type: SettingCreateOrConnectWithoutGameInput,
    });
    t.field("create", { type: nonNull(SettingCreateWithoutGameInput) });
  },
});

const SettingCreateOrConnectWithoutGameInput = inputObjectType({
  name: "SettingCreateOrConnectWithoutGameInput",
  definition(t) {
    t.nonNull.field("create", { type: nonNull(SettingCreateWithoutGameInput) });
    t.nonNull.field("where", { type: nonNull(WhereUniqueInput) });
  },
});

const SettingCreateWithoutGameInput = inputObjectType({
  name: "SettingCreateWithoutGameInput",
  definition(t) {
    t.string("id");
    t.nonNull.string("map");
    t.nonNull.string("mapSize");
    t.nonNull.field("timestamp", { type: DateTime });
    t.nonNull.int("endTurn");
  },
});

based on the Prisma schema of

// ... other models

model Game {
  id        String       @id @default(uuid())
  name      String
  setting   Setting      @relation(fields: [settingId], references: [id])
  teams     InGameTeam[]
  settingId String       @unique
}

model Setting {
  id        String   @id @default(uuid())
  map       String
  mapSize   String
  timestamp DateTime
  endTurn   Int
  game      Game?
}

and generated client of

// ... other types

export type SettingCreateWithoutGameInput = {
  id?: string
  map: string
  mapSize: string
  timestamp: Date | string
  endTurn: number
}

Then shouldn't it be fine without nonNull?
Not sure if this is a bug or by the specification though.

[jasonkuhrt]

This is not a Nexus Prisma issue.

GraphQL does not make a semantic distinction between passing nothing versus passing explicit null in optional fields while Prisma does.

There is no good solution to this.

You can do ?? undefined to remove the null.

[seed-of-apricot]

Thanks for the reply, I'll go with your solution.

[ricardo-valero]

It has been asked before in the previous version of nexus-prisma
graphql-nexus/nexus-plugin-prisma#863

I think reopening this issue should be considered

Maybe this works for some cases
apollographql/apollo-client#2412 (comment)

Also worth checking out

• https://stackoverflow.com/questions/68299326/recursively-convert-object-items-that-are-equal-to-null-to-undefined/70641562#70641562
• https://stackoverflow.com/questions/50374869/generic-way-to-convert-all-instances-of-null-to-undefined-in-typescript/72549576#72549576

But it'd be nice to have a utility that replaces null to undefined when needed

function replaceUnwantedNullToUndefined<GraphQLArg, PrismaArg>(graphqlArg: GraphQLArg) {}