Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatically translating Rust deprecations to GraphQL deprecations #250

Closed
LegNeato opened this issue Sep 14, 2018 · 5 comments
Labels
easy enhancement Improvement of existing features or bugfix Hacktoberfest help wanted

Comments

@LegNeato
Copy link
Member

Conceptually similar to what we do with descriptions (#194), we should automatically translate any #[deprecated] field in a struct using the derives into GraphQL (https://graphql-rust.github.io/types/objects/defining_objects.html#deprecating-fields).

@LegNeato LegNeato added enhancement Improvement of existing features or bugfix help wanted easy labels Sep 14, 2018
@weiznich
Copy link
Contributor

For anyone interested into this: wundergraph already does this, so feel free to "copy" the implementation from there.

@willglynn
Copy link
Contributor

This was merged in #269.

@theduke theduke closed this as completed Nov 4, 2018
@theduke
Copy link
Member

theduke commented Nov 4, 2018

@willglynn thanks for the nudge. ;)

@tjkirch
Copy link

tjkirch commented Mar 22, 2019

Is there a way to make this work for input object fields as well, a la graphql/graphql-spec#525?

@LegNeato
Copy link
Member Author

LegNeato commented Mar 22, 2019

Doesn't look like it is currently supported as it isn't yet in the spec. Feel free to file an enhancement (or a PR!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement Improvement of existing features or bugfix Hacktoberfest help wanted
Projects
None yet
Development

No branches or pull requests

5 participants