Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalarValue custom derive: newtype support #303

Closed
theduke opened this issue Dec 19, 2018 · 1 comment · Fixed by #368
Closed

ScalarValue custom derive: newtype support #303

theduke opened this issue Dec 19, 2018 · 1 comment · Fixed by #368
Assignees
@theduke

Comments

@theduke
Copy link
Member

theduke commented Dec 19, 2018 •
edited
Loading

Extend the (GraphQL)ScalarValue custom derive to support newtype structs.

This should work similar to how serde does it with #[serde(transparent)].

(I'm working on this).

Example:

#[derive(GraphQLScalarValue)]
struct MyCustomId(Uuid);
@mwilliammyers mwilliammyers mentioned this issue Mar 6, 2019
Open
@mwilliammyers
Copy link

Are you still working on this or should I take a crack at it?

@theduke theduke mentioned this issue May 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement newtype derive for scalars. theduke/juniper
2 participants
@theduke @mwilliammyers