-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging/Tracing Support #423
Comments
@mwilliammyers happy to hear your thoughts. I didn't know about |
Ahh, having structured logging makes sense. I completely agree with all of your feature requirements. I am totally fine with creating a PR using something other than I would hope though that we would be open to the possibility of refactoring all of our logging to |
I'm coming from the elixir ecosystem that had a recent push towards adopting a single telemetry facade across the ecosystem. It's already been paying off because I can instrument or log data from any part of our stack (DB driver, GraphQL, HTTP client, etc) through the same interface, without having to fork the libraries. For me, the push towards adopting
To provide a good out-of-the-box experience we can add logging similar to #370 by tapping into those spans via our own subscriber (or better yet, use the tracing_log::TraceLogger which is a subscriber that uses |
This issue aims to discuss the design of logging and tracing support in Juniper.
Requirements:
Crates to consider:
The text was updated successfully, but these errors were encountered: