Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Release changes? #328

Closed
henrinormak opened this issue Jan 23, 2023 · 9 comments
Closed

[QUESTION] Release changes? #328

henrinormak opened this issue Jan 23, 2023 · 9 comments
Assignees

Comments

@henrinormak
Copy link
Contributor

I couldn't find anything on this, but what is the plan with unreleased changes? Currently seems the latest release was in April '21, since then quite a few changes have been merged, but have not been released.

Looking forward to a release, especially for the name feature merged in #326

@SimenB
Copy link
Contributor

SimenB commented Jan 27, 2023

The release action seems to have permission errors: https://github.com/graphql/dataloader/actions/runs/3981356634/jobs/6825040158

@henrinormak
Copy link
Contributor Author

henrinormak commented Jan 27, 2023

Did not realise this was even set up for this repository, do you happen to know who could fix this and get the ball moving? The package is heavily used with 3M+ weekly downloads, yet no release for more than a year...

@SimenB
Copy link
Contributor

SimenB commented Jan 27, 2023

@saihaj maybe?

@saihaj
Copy link
Member

saihaj commented Jan 30, 2023

sorry everyone I was out last week but will try to get something running now that I have access to publish

@saihaj saihaj self-assigned this Jan 30, 2023
@saihaj
Copy link
Member

saihaj commented Feb 2, 2023

@thekevinbrown so looping in you here too for update. So running tests locally I see I may have merged a PR that broke some Flow types. I suspect it is this commit 588a8b6 so trying to see what needs to be fixed (I am not a Flow expert)

This is the type error

CleanShot 2023-02-02 at 02 30 51

@saihaj saihaj mentioned this issue Feb 2, 2023
@SimenB
Copy link
Contributor

SimenB commented Feb 2, 2023

Adding Promise.resolve in there should fix it. I can send a PR within an hour if you don't get to it yourself.

@SimenB
Copy link
Contributor

SimenB commented Feb 2, 2023

Sent: #330

@saihaj
Copy link
Member

saihaj commented Feb 2, 2023

https://github.com/graphql/dataloader/releases/tag/v2.2.0

@saihaj saihaj closed this as completed Feb 2, 2023
@saihaj
Copy link
Member

saihaj commented Feb 2, 2023

I think I may have actually fixed the CI release flow dfb9d93 or maybe it is just me who pushed directly that worked. Very unclear to me cause the errors I saw on CI were related to GH Token. I guess we will figure out if the CI actually works in future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants