Unable to resolve resource on Windows

[Cellule]

Original fix #1715
Regression from #2072
Related graphql/vscode-graphql#254

After some digging, I've confirmed that the bad path is indeed present in the GraphQLCache for the type.
Supposedly the uri is wrong when caching the schema (I wasn't able to debug at that stage because I'm attaching too late to the process)

graphiql/packages/graphql-language-service-server/src/MessageProcessor.ts

Lines 827 to 845 in 484c052

	async _cacheSchemaFile(
	uri: UnnormalizedTypeDefPointer,
	project: GraphQLProjectConfig,
	) {
	uri = uri.toString();
	const isFileUri = existsSync(uri);
	let version = 1;
	if (isFileUri) {
	const schemaUri = URI.parse(path.join(project.dirpath, uri)).toString();
	const schemaDocument = this._getCachedDocument(schemaUri);
	if (schemaDocument) {
	version = schemaDocument.version++;
	}
	const schemaText = readFileSync(uri, { encoding: 'utf-8' });
	this._cacheSchemaText(schemaUri, schemaText, version);
	}
	}

I suspect some vscode-uri.URI.parse(uri).toString() should use vscode-uri.URI.parse(uri).fsPath instead? but my initial attempt failed miserably and I'm a little out of my comfort zone at this point

[acao]

Yes, I had thought we had replaced all of these old URI.parse() statements my bad.

[Cellule]

Alright I gave it another try, from #2072 I put back all the replaced occurrences of pathToFileURL and it works

I think the problem is because it shouldn't be using vscode-uri.URI.parse on filesystem paths, it should only be used on fileURI

I get the following on Windows

> require("vscode-uri").URI.parse("C:\\projects\\graphiql\\packages\\graphql-language-service-server").toString()
'C:%5Cprojects%5Cgraphiql%5Cpackages%5Cgraphql-language-service-server'

> require("url").pathToFileURL("C:\\projects\\graphiql\\packages\\graphql-language-service-server").toString()
'file:///C:/projects/graphiql/packages/graphql-language-service-server

[Cellule]

Actually, it looks like the proper fix is to use vscode-uri.URI.file().toString() in place where we have a filesystem path
As shown here https://github.com/microsoft/vscode-uri

> require("vscode-uri").URI.file("C:\\projects\\graphiql\\packages\\graphql-language-service-server").toString()
'file:///c%3A/projects/graphiql/packages/graphql-language-service-server'

I tried it real quick and it seems to work