Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ligatures #3144

Closed
timuric opened this issue Apr 20, 2023 · 2 comments · Fixed by #3197
Closed

Remove ligatures #3144

timuric opened this issue Apr 20, 2023 · 2 comments · Fixed by #3197
Labels
enhancement graphiql

Comments

@timuric
Copy link

timuric commented Apr 20, 2023

GraphQL syntax doesn't benefit from ligatures, and can be confusing when data is displayed, for instance xxxx1x1 looks like xxx1×1
image

.graphiql-container * { font-variant-ligatures: none; }
@dimaMachina
Copy link
Collaborator

I don't have this problem
image

@thomasheyenbrock
Copy link
Collaborator

This is reproducible:

Current state Desired state (after adding font-variant-ligatures: none)
CleanShot 2023-04-25 at 12 24 00@2x CleanShot 2023-04-25 at 12 25 58@2x

Notice the subtle difference of the x before and the x between the 1s.

@dimaMachina dimaMachina mentioned this issue May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement graphiql
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove confusing ligatures, set font-variant-ligatures: none dimaMachina/graphiql
3 participants
@timuric @dimaMachina @thomasheyenbrock