Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] #3310 broke the schema demo #3317

Closed
1 of 4 tasks
acao opened this issue Jul 2, 2023 · 2 comments · Fixed by #3353
Closed
1 of 4 tasks

[graphiql] #3310 broke the schema demo #3317

acao opened this issue Jul 2, 2023 · 2 comments · Fixed by #3353

Comments

@acao
Copy link
Member

acao commented Jul 2, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

the schema-demo function on netlify fails with a 500 error and no response or logs on netlify functions

Expected Behavior

schema demo introspection requests and graphql ops should suceed

Steps To Reproduce

1. https://graphiql-test.netlify.app
2. observe failing schema

Module pattern

  • graphiql-umd
  • graphiql-esm
  • graphiql-commonjs

Environment

- GraphiQL Version:
- OS:
- Browser:
- Bundler:
- `react` Version:
- `graphql` Version:

Anything else?

No response

@acao
Copy link
Member Author

acao commented Jul 2, 2023

should probably just drop express entirely

also, this bug form is a bit wonky. should have rich input for steps to reproduce at least

@acao
Copy link
Member Author

acao commented Jul 5, 2023

to note, the upgrade with express-graphql is still working fine for e2e tests, but the serverless wrapper for express seems to not be compatible with it, and throws a mystery 500 error

In this PR, I'm adding a netlify handler to our sister repo so that we can implement this without the antiquated express compat layer
graphql/graphql-http#96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant