Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] Regression in documentation explorer search when clicking on results in dropdown #3842

Closed
1 task done
emmenko opened this issue Dec 17, 2024 · 2 comments · Fixed by #3843
Closed
1 task done

Comments

@emmenko
Copy link

emmenko commented Dec 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When searching in the documentation explorer, attempting to click on one of the items in the dropdown doesn't yield anything. The dropdown disappears and the search results (documentation) are not changed.

Expected Behavior

When searching in the documentation explorer, attempting to click on one of the items in the dropdown should go to the selected definition and the search documentation should change.

Steps To Reproduce

  1. Open the Documentation explorer
  2. Click on the search input
  3. Type something
  4. Click with the cursor on one of the dropdown options
  5. The dropdown disappear
  6. Nothing happens, the search results (documentation) don't change

Environment

  • GraphiQL Version: 3.8.1
  • OS: macos v14
  • Browser: Arc
  • Bundler:
  • react Version: 17.0.2
  • graphql Version: 16.9.0
  • @graphiql/plugin-explorer Version: 3.2.5
  • @graphiql/react Version: 0.28.1
  • @graphiql/toolkit Version: 0.11.1

Anything else?

This actually works with the following versions

  • @graphiql/plugin-explorer Version: 3.2.3
  • @graphiql/react Version: 0.27.1
  • @graphiql/toolkit Version: 0.11.1
  • graphiql Version: 3.8.0

It seems it was fixed some time ago (#3364) but the related code was changed / removed in #3821.

@dimaMachina
Copy link
Collaborator

@emmenko thanks for reporting, fixed in https://github.com/graphql/graphiql/releases/tag/graphiql%403.8.3, lmk if you'll found more regression

@emmenko
Copy link
Author

emmenko commented Dec 17, 2024

Thanks for the quick fix, it works as expected now 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants