Skip to content

Commit 10b1c27

Browse files
committed
rename SubsequentResultRecord
SubsequentResultRecord => DeliveryGroup
1 parent f772646 commit 10b1c27

File tree

3 files changed

+22
-24
lines changed

3 files changed

+22
-24
lines changed

src/execution/IncrementalGraph.ts

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ import type { GraphQLError } from '../error/GraphQLError.js';
77

88
import type {
99
DeferredFragmentRecord,
10+
DeliveryGroup,
1011
IncrementalDataRecord,
1112
IncrementalDataRecordResult,
1213
PendingExecutionGroup,
1314
StreamItemRecord,
1415
StreamRecord,
15-
SubsequentResultRecord,
1616
SuccessfulExecutionGroup,
1717
} from './types.js';
1818
import { isDeferredFragmentRecord, isPendingExecutionGroup } from './types.js';
@@ -21,7 +21,7 @@ import { isDeferredFragmentRecord, isPendingExecutionGroup } from './types.js';
2121
* @internal
2222
*/
2323
export class IncrementalGraph {
24-
private _rootNodes: Set<SubsequentResultRecord>;
24+
private _rootNodes: Set<DeliveryGroup>;
2525

2626
private _completedQueue: Array<IncrementalDataRecordResult>;
2727
private _nextQueue: Array<
@@ -36,8 +36,8 @@ export class IncrementalGraph {
3636

3737
getNewRootNodes(
3838
incrementalDataRecords: ReadonlyArray<IncrementalDataRecord>,
39-
): ReadonlyArray<SubsequentResultRecord> {
40-
const initialResultChildren = new Set<SubsequentResultRecord>();
39+
): ReadonlyArray<DeliveryGroup> {
40+
const initialResultChildren = new Set<DeliveryGroup>();
4141
this._addIncrementalDataRecords(
4242
incrementalDataRecords,
4343
undefined,
@@ -103,7 +103,7 @@ export class IncrementalGraph {
103103

104104
completeDeferredFragment(deferredFragmentRecord: DeferredFragmentRecord):
105105
| {
106-
newRootNodes: ReadonlyArray<SubsequentResultRecord>;
106+
newRootNodes: ReadonlyArray<DeliveryGroup>;
107107
successfulExecutionGroups: ReadonlyArray<SuccessfulExecutionGroup>;
108108
}
109109
| undefined {
@@ -145,16 +145,14 @@ export class IncrementalGraph {
145145
this._removeRootNode(streamRecord);
146146
}
147147

148-
private _removeRootNode(
149-
subsequentResultRecord: SubsequentResultRecord,
150-
): void {
151-
this._rootNodes.delete(subsequentResultRecord);
148+
private _removeRootNode(deliveryGroup: DeliveryGroup): void {
149+
this._rootNodes.delete(deliveryGroup);
152150
}
153151

154152
private _addIncrementalDataRecords(
155153
incrementalDataRecords: ReadonlyArray<IncrementalDataRecord>,
156154
parents: ReadonlyArray<DeferredFragmentRecord> | undefined,
157-
initialResultChildren?: Set<SubsequentResultRecord> | undefined,
155+
initialResultChildren?: Set<DeliveryGroup> | undefined,
158156
): void {
159157
for (const incrementalDataRecord of incrementalDataRecords) {
160158
if (isPendingExecutionGroup(incrementalDataRecord)) {
@@ -183,9 +181,9 @@ export class IncrementalGraph {
183181
}
184182

185183
private _promoteNonEmptyToRoot(
186-
maybeEmptyNewRootNodes: Set<SubsequentResultRecord>,
187-
): ReadonlyArray<SubsequentResultRecord> {
188-
const newRootNodes: Array<SubsequentResultRecord> = [];
184+
maybeEmptyNewRootNodes: Set<DeliveryGroup>,
185+
): ReadonlyArray<DeliveryGroup> {
186+
const newRootNodes: Array<DeliveryGroup> = [];
189187
for (const node of maybeEmptyNewRootNodes) {
190188
if (isDeferredFragmentRecord(node)) {
191189
if (node.pendingExecutionGroups.size > 0) {
@@ -222,7 +220,7 @@ export class IncrementalGraph {
222220

223221
private _addDeferredFragment(
224222
deferredFragmentRecord: DeferredFragmentRecord,
225-
initialResultChildren: Set<SubsequentResultRecord> | undefined,
223+
initialResultChildren: Set<DeliveryGroup> | undefined,
226224
): void {
227225
if (this._rootNodes.has(deferredFragmentRecord)) {
228226
return;

src/execution/IncrementalPublisher.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import type {
1010
CompletedExecutionGroup,
1111
CompletedResult,
1212
DeferredFragmentRecord,
13+
DeliveryGroup,
1314
ExperimentalIncrementalExecutionResults,
1415
IncrementalDataRecord,
1516
IncrementalDataRecordResult,
@@ -20,7 +21,6 @@ import type {
2021
PendingResult,
2122
StreamItemsResult,
2223
SubsequentIncrementalExecutionResult,
23-
SubsequentResultRecord,
2424
} from './types.js';
2525
import {
2626
isCancellableStreamRecord,
@@ -92,7 +92,7 @@ class IncrementalPublisher {
9292
}
9393

9494
private _toPendingResults(
95-
newRootNodes: ReadonlyArray<SubsequentResultRecord>,
95+
newRootNodes: ReadonlyArray<DeliveryGroup>,
9696
): Array<PendingResult> {
9797
const pendingResults: Array<PendingResult> = [];
9898
for (const node of newRootNodes) {

src/execution/types.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export interface PendingExecutionGroup {
212212
result: ThunkIncrementalResult<CompletedExecutionGroup>;
213213
}
214214

215-
export type SubsequentResultRecord = DeferredFragmentRecord | StreamRecord;
215+
export type DeliveryGroup = DeferredFragmentRecord | StreamRecord;
216216

217217
/** @internal */
218218
export class DeferredFragmentRecord {
@@ -222,7 +222,7 @@ export class DeferredFragmentRecord {
222222
parent: DeferredFragmentRecord | undefined;
223223
pendingExecutionGroups: Set<PendingExecutionGroup>;
224224
successfulExecutionGroups: Set<SuccessfulExecutionGroup>;
225-
children: Set<SubsequentResultRecord>;
225+
children: Set<DeliveryGroup>;
226226

227227
constructor(
228228
path: Path | undefined,
@@ -239,9 +239,9 @@ export class DeferredFragmentRecord {
239239
}
240240

241241
export function isDeferredFragmentRecord(
242-
subsequentResultRecord: SubsequentResultRecord,
243-
): subsequentResultRecord is DeferredFragmentRecord {
244-
return subsequentResultRecord instanceof DeferredFragmentRecord;
242+
deliveryGroup: DeliveryGroup,
243+
): deliveryGroup is DeferredFragmentRecord {
244+
return deliveryGroup instanceof DeferredFragmentRecord;
245245
}
246246

247247
export interface StreamItemResult {
@@ -271,9 +271,9 @@ export interface CancellableStreamRecord extends StreamRecord {
271271
}
272272

273273
export function isCancellableStreamRecord(
274-
subsequentResultRecord: SubsequentResultRecord,
275-
): subsequentResultRecord is CancellableStreamRecord {
276-
return 'earlyReturn' in subsequentResultRecord;
274+
deliveryGroup: DeliveryGroup,
275+
): deliveryGroup is CancellableStreamRecord {
276+
return 'earlyReturn' in deliveryGroup;
277277
}
278278

279279
export type IncrementalDataRecord = PendingExecutionGroup | StreamRecord;

0 commit comments

Comments
 (0)