Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'lexographicSortSchema' #1208

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Add 'lexographicSortSchema' #1208

merged 1 commit into from
Jan 29, 2018

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Jan 22, 2018 •
edited
Loading

@leebyron Following your suggestion in #1199 I reimplemented lexographicSortSchema without changing any existing functionality or adding new API.

Can you please review it?

@leebyron leebyron merged commit 6a1eddf into graphql:master Jan 29, 2018
@leebyron
Copy link
Contributor

Excellent work, thanks for adding a great test suite

@IvanGoncharov IvanGoncharov deleted the lexographicSortSchema branch January 29, 2018 21:05
@IvanGoncharov IvanGoncharov mentioned this pull request Jan 29, 2018
Closed
@marktani
Copy link

Isn't it called lexicographic instead of lexographic?

@IvanGoncharov
Copy link
Member Author

@marktani Good catch! You rock in spelling 🎸
Wikipedia:Lexicographical_order + on GitHub it 8 matches vs 281 matches

I will create PR in a minute

@IvanGoncharov IvanGoncharov mentioned this pull request Jan 30, 2018
Merged
This was referenced Mar 19, 2018
Open
Closed
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leebyron leebyron Awaiting requested review from leebyron

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanGoncharov @leebyron @marktani @facebook-github-bot