Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in extensions-test #2168

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

Cito
Copy link
Member

@Cito Cito commented Sep 12, 2019

No description provided.

@Cito Cito force-pushed the fix-extensions-test branch from 3a505cb to 6c66cbd Compare September 12, 2019 16:18
const fieldExtensions = Object.freeze({ SomeFieldExt: 'field' });
const argExtensions = Object.freeze({ SomeArgExt: 'arg' });

const someInterface = new GraphQLObjectType({
const someInterface = new GraphQLInterfaceType({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big one. So I didn't test GraphQLInterfaceType at all 🤦‍♂
@Cito Thanks a lot 👍

@IvanGoncharov IvanGoncharov merged commit a53d5b3 into graphql:master Sep 12, 2019
@Cito Cito deleted the fix-extensions-test branch September 13, 2019 10:39
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants