-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Faster Algorithm For OverlappingFieldsCanBeMerged #2185
Comments
@SimonAdameit Thanks a lot for sharing 👍 Its super useful ATM we preparing for TS conversion so we in a feature freeze state but it would be at the top queue after conversion is finished. |
with TS conversion finished, this should be in the news! |
At XING we are using the Sangria implementation of GraphQL. The implementation of the OverlappingFieldsCanBeMerged validation in Sangria follows the one in this reference implementation. We experienced performance problems with it related to the number of fragments. After we invested some time to solve it, I came up with a better algorithm, that we are using now.
The proposal would be to use this algorithm in the reference implementation. Below is an example benchmark graph showing the performance improvement for multiple fragments in the same selection set.
The text was updated successfully, but these errors were encountered: