Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented breaking change in 0.9.2 #811

Closed
kassens opened this issue Apr 16, 2017 · 5 comments
Closed

Undocumented breaking change in 0.9.2 #811

kassens opened this issue Apr 16, 2017 · 5 comments

Comments

@kassens
Copy link
Contributor

kassens commented Apr 16, 2017

12b2137 introduced a breaking change where non-nullable fields are no longer considered leaf types by isLeafType.

See the breakage reported in facebook/relay#1614.

@leebyron
Copy link
Contributor

This one's ambiguous, but I agree should have been included on the changelog. It was a bug fix, but that did result in behavior change

@kassens
Copy link
Contributor Author

kassens commented Apr 17, 2017

Feel free to close if the change log is immutable.

@wincent
Copy link
Contributor

wincent commented Apr 17, 2017

It's not immutable.

@wincent
Copy link
Contributor

wincent commented Apr 17, 2017

Note that it was already in the changelog as:

but at the time I wrote it I didn't realize it was a breaking change. I've edited the release notes to instead say:

Feel free to edit them further if you think they can be improved.

@wincent wincent closed this as completed Apr 17, 2017
@kassens
Copy link
Contributor Author

kassens commented Apr 17, 2017

This is perfect. Flow checking/type safety sounded internal or that they wouldn't affect runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants