-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented breaking change in 0.9.2 #811
Comments
This one's ambiguous, but I agree should have been included on the changelog. It was a bug fix, but that did result in behavior change |
Feel free to close if the change log is immutable. |
It's not immutable. |
Note that it was already in the changelog as:
but at the time I wrote it I didn't realize it was a breaking change. I've edited the release notes to instead say:
Feel free to edit them further if you think they can be improved. |
This is perfect. Flow checking/type safety sounded internal or that they wouldn't affect runtime. |
12b2137 introduced a breaking change where non-nullable fields are no longer considered leaf types by
isLeafType
.See the breakage reported in facebook/relay#1614.
The text was updated successfully, but these errors were encountered: