Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

GraphQL Language Service master task #3

Closed
4 of 7 tasks
asiandrummer opened this issue Dec 9, 2016 · 8 comments
Closed
4 of 7 tasks

GraphQL Language Service master task #3

asiandrummer opened this issue Dec 9, 2016 · 8 comments

Comments

@asiandrummer
Copy link
Contributor

asiandrummer commented Dec 9, 2016

TODO before the release

  • Complete test suites imported from codemirror-graphql and written for server/configuration/utils.
    • Improve test suites for the parser
  • Command-line interface improvement to support locating .graphqlrc
  • Better error Handling - find erroneous use cases that exits the server or sends a RPC message with 'error' type.

Nice-to-haves before/after the release

  • caching unsaved/edited file contents in GraphQLCache.
  • Custom validation rules
  • pretty-printed CLI outputs

Also, I'm not sure where this one fits but https://code.visualstudio.com/blogs/2016/06/27/common-language-protocol summarizes the architecture for implemented GraphQL server interface pretty well as a superset. It's probably worth mentioning and finding a place to collaborate with this protocol.

Please feel free to add/edit the items above.

@kumarharsh
Copy link

kumarharsh commented Jan 17, 2017

@asiandrummer There is already a project: https://github.com/Mayank1791989/gql created by @Mayank1791989, who has done some awesome work to make the plugin work by providing a language service interface which works across different editors (vscode/sublime/atom). Would you be interested in merging the efforts? I think that way the development on the plugin can be boosted a lot.

@asiandrummer
Copy link
Contributor Author

@kumarharsh that's awesome! I'd love to work together on this. I'm currently looking at the code in gql repo, and it seems like it's reusing most of codemirror-graphql for the parser/language service interfaces, which this library is also doing. The RPC code is also interesting - I'd love to chat about merging the efforts together.

I've added @Mayank1791989 to this repo as a contributor - please feel free to take a look at what I've done and let's discuss how we can merge the efforts together!

.gqlconfig is also an interesting one - there's an ongoing effort to generalize how GraphQL configurations should be set up between me and @schickling (graphql-config). We should definitely talk about this shared configuration for GraphQL as well - let me write up a proposal-kind of document and share amongst you guys, probably in graphql-config repo. FWIW, we've been calling it .graphqlrc :D

For my side of progress, Nuclide integration for this library is close to be released to the public, and I'll expose this repo to the public when that happens. I'd love to collaborate to support other IDEs!

@kumarharsh
Copy link

Sure, that's great to hear. :-) I'll have a deeper look into this project later this week.

@schickling
Copy link
Contributor

Sorry for the radio silence from my side @asiandrummer. I'm very much looking forward to the proposal for graphql-config as more and more people seem to adopt and start using it.

Any timeline for this?

@asiandrummer
Copy link
Contributor Author

kamilkisiela/graphql-config#16 tracks the ongoing graphql-config discussion

@asiandrummer
Copy link
Contributor Author

This repo will go live tomorrow - when it does I'll track the unfinished nice-to-haves in separate issues, and close this one!

@jimkyndemeyer
Copy link
Contributor

I'm worried that facebook/watchman#19 is still open. While I use a mac at work, I do have a PC at home, and cutting off the Windows developers seems like a bad idea.

@wincent
Copy link
Contributor

wincent commented May 26, 2017

As this issue is super old now, going to close it. Any remaining items we want to deal with can get issues of their own.

@wincent wincent closed this as completed May 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants