-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RenderPageOptions.settings is ignored #741
Comments
I'm seeing this as well, trying the minimal page with 1.7.0 GraphQLPlayground.init(root, {
endpoint: location.protocol + '//' + path,
settings: {
'request.credentials': 'same-origin'
}
}) Settings seem to be ignored both with empty localStorage and after first load -- but can still be changed manually from the interface. |
it looks to be writing the settings to the DOM prior to client initialisation but is failing to hydrate the redux store settings from props |
Any progress here? |
seeing this issue as well when configuring through apollo 2, would like to see this fixed |
It should be fixed, if its still problem please reopen. |
This issue pertains to the following package(s):
What OS and OS version are you experiencing the issue(s) on?
OSX
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
1.7.0
What is the expected behavior?
When providing RenderPageOptions.settings the page should open with those effective, instead of the default values.
What is the actual behavior?
The "settings" are ignored, the page always renders with the default settings, the served HTML actually contains the settings given in code. Tested with Chrome incognito window, not a browser caching issue. Once the page opens it is possible to changes the settings in browser.
What steps may we take to reproduce the behavior?
Just try to provide any settings to the renderPlaygroundPage or any of the middleware packages.
Please provide a gif or image of the issue for a quicker response/fix.
The text was updated successfully, but these errors were encountered: