Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file pointed at in package.json is not included in released packages #959

Closed
codepunkt opened this issue Feb 7, 2019 · 1 comment

Comments

@codepunkt
Copy link

codepunkt commented Feb 7, 2019

The package.json files of the packages in this project have a "license" field that says "SEE LICENSE IN LICENSE".

License automation, which is necessary and important in certain contexts, reads this "license" field to do it's magic and usually expects a valid spdx license identifier string. "SEE LICENSE IN LICENSE" is a special case, which results in reading the LICENSE file for license information. This file does not exist as part of the files released to npm - which means that effectively, your packages released to npm do not carry any licensing information.

Which is bad and might lead to companies not being able to use them due to licensing policy.

Please either

  • include the LICENSE file from repository in every release of every package (not great, but still better than the status quo)
  • change the "license" field to the appropriate spdx license identifier (better)
  • change the "license" field to the appropriate spdx license identifier and include the LICENSE file with license text and copyright information (this is what i would suggest)

For more information, see the readme of webpack-license-plugin. Should anything be unclear, please ask!

@mmmeff
Copy link
Contributor

mmmeff commented Feb 8, 2019

+1

This broke my team's gatsby project via automation around infosec/licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants