Skip to content

Commit 492c556

Browse files
JoviDeCroockbenjie
andcommitted
Apply suggestions from code review
Co-authored-by: Benjie <benjie@jemjie.com>
1 parent 8be0561 commit 492c556

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

spec/Section 5 -- Validation.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ FieldsInSetCanMerge(set):
425425
{visitedSelections}.
426426
- For each {spreadsForName} as {name} and {spreads}:
427427
- Each entry in {spreads} must have identical sets of arguments to each other entry in {spreads}.
428-
- Let {fieldsForName} be the set of selections with a given response name in
428+
- Let {fieldsForName} be the set of field selections with a given response name in
429429
{visitedSelections}.
430430
- Given each pair of members {fieldA} and {fieldB} in {fieldsForName}:
431431
- {SameResponseShape(fieldA, fieldB)} must be true.
@@ -731,7 +731,7 @@ fragment invalidArgName on Dog {
731731
}
732732
```
733733

734-
and this is also invalid as the variable `dogCommand` is not defined on fragment
734+
and this is also invalid as the argument `dogCommand` is not defined on fragment
735735
`withFragmentArg`.
736736

737737
```graphql counter-example
@@ -1989,10 +1989,7 @@ fragment fragmentArgUnused($atOtherHomes: Boolean) on Dog {
19891989
}
19901990
```
19911991

1992-
This document is invalid: even though `fragmentArgUnused` is spread with the
1993-
argument `atOtherHomes` and `$atOtherHomes` is defined as an operation variable,
1994-
there is never a variable `$atOtherHomes` used within the scope of
1995-
`fragmentArgUnused`.
1992+
This document is invalid: fragment `fragmentArgUnused` defines a fragment variable `$atOtherHomes`, but this variable is not used within this fragment.
19961993

19971994
### All Variable Usages Are Allowed
19981995

0 commit comments

Comments
 (0)