Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API valueFromAST is missing #685

Closed
anhldbk opened this issue Apr 4, 2019 · 2 comments
Closed

API valueFromAST is missing #685

anhldbk opened this issue Apr 4, 2019 · 2 comments

Comments

@anhldbk
Copy link

anhldbk commented Apr 4, 2019

Hi there,

This section about GraphQL utitilities does NOT contain any information about valueFromAST: https://graphql.github.io/graphql-js/utilities/

Should I make a PR against this missing?
@carolstran
Copy link
Member

👋🏼 @anhldbk, thanks for opening an issue on the GraphQL documentation! You're right, it seems that we have docs on astFromValue but not valueFromAST. I've never used it personally, but I could imagine it being a good addition.

@IvanGoncharov, what do you think?

@IvanGoncharov
Copy link
Member

@anhldbk @carolstran graphql-js docs are a mess at the moment. It's my next goal to address it after TS conversion, tracked in graphql/graphql-js#1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anhldbk @IvanGoncharov @carolstran