Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have a non-dev-mode install of graspologic as part of CI/CD workflow #1009

Open
bdpedigo opened this issue Jan 3, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bdpedigo
Copy link
Collaborator

bdpedigo commented Jan 3, 2023

Somehow #983 was not caught by our CI/CD workflow

I suspect this is because graspologic is being installed with development dependencies in most (all?) places in our workflow, and typing_extensions was probably being installed as a dependency of a development dependency. I think this is why I also did not notice as I almost always install locally in dev mode.

We should

  1. check if the above is the case and if so,
  2. add a simple step to the workflow that simply installs graspologic in non-dev mode.

If I'm wrong about the above, then I'd still like to figure out how that snuck past us

@bdpedigo bdpedigo added the enhancement New feature or request label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant