Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] What does "Spectral Vertex Nomination" implement? #1030

Open
ebridge2 opened this issue Apr 17, 2023 · 1 comment
Open

[BUG] What does "Spectral Vertex Nomination" implement? #1030

ebridge2 opened this issue Apr 17, 2023 · 1 comment
Labels
small fixing some small issue, 1-5 lines of code

Comments

@ebridge2
Copy link
Collaborator

ebridge2 commented Apr 17, 2023

Expected Behavior

One of the procedures from the reference papers to be implemented.

Actual Behavior

I don't think any of the procedures in the reference papers reflect the algorithm that is implemented, as the output does not address the vertex nomination problem, from Fishkind 2015:
image

The output provides a nomination list for each seed node, which is not the vertex nomination problem as-described in the papers linked, but a closely related (albeit distinct) problem.

@ebridge2 ebridge2 added the bug Something isn't working label Apr 17, 2023
@ebridge2
Copy link
Collaborator Author

ebridge2 commented Apr 17, 2023

Clarified with @bdpedigo that it uses a definition of vertex nomination/proposes a solution distinct from those presented in the papers. Suggested fix: clarification as to the papers it is using.

@ebridge2 ebridge2 added small fixing some small issue, 1-5 lines of code and removed bug Something isn't working labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small fixing some small issue, 1-5 lines of code
Projects
None yet
Development

No branches or pull requests

1 participant