Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Get deployment back on track #172

Closed
chadwhitacre opened this issue Apr 25, 2017 · 15 comments
Closed

Get deployment back on track #172

chadwhitacre opened this issue Apr 25, 2017 · 15 comments

Comments

@chadwhitacre
Copy link
Contributor

chadwhitacre commented Apr 25, 2017

Currently deployment is in some kinda state. My local git repo is out of sync with prod. I don't have time to debug right now, and #171 may be the answer anyway. Flagging in a ticket for now.

@techtonik
Copy link
Contributor

@whit537 hi, is there any progress with deployment on your side? At least would be nice to see errors.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented May 7, 2017

Sadly no. I'm deep into gratipay/inside.gratipay.com#948 right now and am not seeing this as a priority unfortunately. Maybe you can convince @rohitpaulk or @clone1018 to work on this with you sooner than I'll be able to get to it? 😞

@rohitpaulk
Copy link
Contributor

Hmm, why aren't we just hosting this on Heroku :/ Costs?

@rohitpaulk
Copy link
Contributor

I'd be okay with working on getting this hosted on Heroku, so that we never have to deal with it again :)

Heroku is a provider we trust, all our other apps are hosted there, and they have the features required to host this app. I don't see a reason to involve another provider other than the cost, which would be just $7/month in case of Heroku

@mattbk
Copy link
Contributor

mattbk commented May 7, 2017

Where is it hosted now?

@clone1018
Copy link
Contributor

A DigitalOcean droplet

@techtonik
Copy link
Contributor

Diversification is good. Alternative platforms for some services helps code to be more universal. Just need somebody with DigitalOcean access to push the changes.

@chadwhitacre
Copy link
Contributor Author

While I agree in principle that diversification is good and that portability generally improves code, I think at this stage of the game agility is more important. By standardizing on Heroku we reduce mental overhead and we can move faster. +1 for Heroku.

@clone1018
Copy link
Contributor

If we move this to Heroku we get insta-ssl also without any .well-known craziness.

@mattbk
Copy link
Contributor

mattbk commented May 8, 2017

I have no problem with it (although #163 (comment) still stands).

@clone1018
Copy link
Contributor

I've been messing around on heroku to get grtp potentially moved over and it was very simple.

The setup was essentially just specifying two buildpacks in the heroku config:

  1. index=1 heroku/nodejs
  2. index=2 https://github.com/heroku/heroku-buildpack-static.git

And adding a postinstall of make build. So really what's happening is heroku is installing nodejs for the build and then a simple nginx server serves up the www/ directory

Here's a demo:
https://grtp.herokuapp.com/v2.js

Deployment would be as simple as ./deploy.sh or git push heroku master depending on how we want it.

@techtonik
Copy link
Contributor

There are two important issues beyond Heroku that don't allow me to do changes:

  1. Dalek tests fail with command line runner #170
  2. unable to upgrade Grunt Competence Debt #107 (comment)

@clone1018
Copy link
Contributor

I think we should try simplifying the stack. JavaScript has changed a lot since grtp started. What alternatives are there for testing now @techtonik ? Should we be using a simpler gulp process or webpack also?

@techtonik
Copy link
Contributor

@clone1018 I have almost no idea about what is happening on JavaScript world. @rummik should now better.

@techtonik
Copy link
Contributor

Moved to Heroku in #173 Deployment now works - https://grtp.co/v2.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants