Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rdpdr/mod.rs into further submodules #13499

Closed
ibeckermayer opened this issue Jun 14, 2022 · 0 comments
Closed

Refactor rdpdr/mod.rs into further submodules #13499

ibeckermayer opened this issue Jun 14, 2022 · 0 comments
Assignees
@LKozlowski @ibeckermayer
Labels
desktop-access

Comments

@ibeckermayer
Copy link
Contributor

ibeckermayer commented Jun 14, 2022 •
edited
Loading

Originally posted by @zmb3 in #12717 (review)

An obvious starting point: similar to how we have an scard::Client, we should likely create a Client in a separate module for directory sharing (perhaps ds::Client). Essentially tuck all of this stuff and the functions that rely on it into their own module.
@ibeckermayer ibeckermayer self-assigned this Jun 14, 2022
@ibeckermayer ibeckermayer mentioned this issue Jun 14, 2022
Merged
@zmb3 zmb3 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LKozlowski LKozlowski

@ibeckermayer ibeckermayer

Labels
desktop-access
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LKozlowski @zmb3 @ibeckermayer