Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Component Library: Buttons #22806

Closed
16 tasks
roraback opened this issue Mar 8, 2023 · 3 comments
Closed
16 tasks

Design Component Library: Buttons #22806

roraback opened this issue Mar 8, 2023 · 3 comments
Assignees

Comments

@roraback
Copy link
Contributor

roraback commented Mar 8, 2023

Button Types:

  • Primary Button
  • Minimal Button
  • Danger Button
  • Icon-only Minimal Button
  • (Do we currently have a need for Primary/Danger icon-only buttons? If not, we can punt on that until we come up with a need for them)

Button Sizes:

  • Small
  • Medium
  • Large

Each should have Light and Dark theme with the following states for each:

  • Default
  • Hover
  • Active/Pressed
  • Focus
  • Disabled
  • Interaction links between states for prototyping

Buttons should also have hidden (by default)

  • left icon and
  • right icon
    that we can show as needed in designs.
@rishibarbhaya-design
Copy link

Component: Buttons (btn)
Inclusion: Light and Dark Version

Link: https://www.figma.com/file/Gpjs9vjhzUKF1GDbeG9JGE/Application-Design-System?node-id=6642%3A29063&t=kQYtyY6zBmtNvlMs-1
Go to file > Buttons (btn)

@zmb3
Copy link
Collaborator

zmb3 commented Nov 14, 2023

@roraback my understanding is that the design system has been updated w.r.t buttons and it's just on engineering to make the updates now. Is this correct?

If so, can we close this issue out?

@zmb3
Copy link
Collaborator

zmb3 commented Feb 5, 2024

This is tracked as a development task in #37260, so I assume there is no more design work to be done and this can be closed. Feel free to reopen if I am mistaken.

@zmb3 zmb3 closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants