Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Timezone / UTC #2800

Closed
klizhentas opened this issue Jun 27, 2019 · 7 comments
Closed

Review Timezone / UTC #2800

klizhentas opened this issue Jun 27, 2019 · 7 comments

Comments

@klizhentas
Copy link
Contributor

Description

Currently, the UI in teleport says that session times are displayed in UTC, however uses local time instead.

In addition to that, date picker picks the time using local time and converts to UTC. Instead, I suggest to change it to time picker instead and always use UTC as well.

@klizhentas klizhentas added this to the 4.1 "Seattle" milestone Jun 27, 2019
@kontsevoy kontsevoy modified the milestone: 4.1 "Seattle" Jun 27, 2019
@klizhentas klizhentas assigned alex-kovoy and unassigned kontsevoy and benarent Jun 27, 2019
@klizhentas
Copy link
Contributor Author

Seems like everyone is in agreement then, @alex-kovoy this one goes to you then.

@benarent
Copy link
Contributor

benarent commented Jul 30, 2019

We discussed this yesterday, let's show the current UTC time in the UI. We can look at extra user preferences in a future release.

@alex-kovoy
Copy link
Contributor

alex-kovoy commented Sep 5, 2019

The issue with the "stored sessions" will disappear after 4.2 release because we no longer need to have session end event to display it. That was the main reason for people complains because start and end events might not fall into the same selected range. Also, due to limitation on the maximum number of returned events, some "stored sessions" might not be shown as well although both events would belong to selected date range.

In other words, we are replacing stored session abstraction with the Audit Log which will display events as is.

As for DatePicker -> we will continue showing local dates inside the picker.
As for DataTable -> we will display UTC dates in columns.

@klizhentas
Copy link
Contributor Author

@alex-kovoy this really does not strike me as intuitive - if we are displaying times in UTC, why do we pick times with a local date picker?

@klizhentas
Copy link
Contributor Author

cc @benarent @alexwolfe

@benarent
Copy link
Contributor

benarent commented Sep 5, 2019

To help discuss the edge cases and visually show the issues / bugs, I've created this docs. https://docs.google.com/document/d/1dE--oGaAcU38fnM5h1DeUQjqS5e-4QRkEIclgiATfsA/edit#

@benarent benarent modified the milestones: 4.2 "Alameda", 4.3 "Concord" Nov 1, 2019
@benarent benarent changed the title Display all times in UTC Review Timezone / UTC May 27, 2020
@zmb3
Copy link
Collaborator

zmb3 commented Aug 15, 2022

We display the audit log in UTC now.

@zmb3 zmb3 closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants