Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar used in event log is weird #4051

Closed
webvictim opened this issue Jul 15, 2020 · 2 comments · Fixed by gravitational/webapps#124
Closed

Grammar used in event log is weird #4051

webvictim opened this issue Jul 15, 2020 · 2 comments · Fixed by gravitational/webapps#124
Assignees

Comments

@webvictim
Copy link
Contributor

webvictim commented Jul 15, 2020

What happened: Some of the grammar used in the event log doesn't read very well.

User [gus@gravitational.com] has ended a few seconds interactive session [061ec026-c6b5-11ea-a1ee-ce661b0ed760] on node [gusdemo-root-node-0]

Screenshot 2020-07-15 13 06 50

A longer session doesn't quite look right either:

User [gus@gravitational.com] has ended 4 minutes interactive session [6fd8d7fe-c6b5-11ea-a1ee-ce661b0ed760] on node [gusdemo-root-auth-0]

What you expected to happen: This should read:

"User [gus@gravitational.com] has ended an interactive session lasting a few seconds [061ec026-c6b5-11ea-a1ee-ce661b0ed760] on node [gusdemo-root-node-0]"

"User [gus@gravitational.com] has ended an interactive session lasting 4 minutes [6fd8d7fe-c6b5-11ea-a1ee-ce661b0ed760] on node [gusdemo-root-auth-0]"

How to reproduce it (as minimally and precisely as possible): Start a session. Stop session. Observe audit log.

Environment

  • Teleport version (use teleport version): Teleport Enterprise v4.3.0git:v4.3.0-0-g73b68f401 go1.13.2
@alex-kovoy
Copy link
Contributor

@benarent are you OK with proposed gramma?

@benarent
Copy link
Contributor

Yes. @webvictim is the Grammar Professor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants